KIP, Powerprint Request software -samba

[James Peach]

On Mon, Aug 16, 2004 at 10:45:14AM -0700, Jeremy Allison wrote:
> On Mon, Aug 16, 2004 at 10:59:43AM +1100, James Peach wrote:
> > 
> > It just so happens that some of our customers have been seeing this
> > problem with the findfirst code. I spent a chunk of last week putting
> > together the attached patch (against 3.0.6rc2) which
> >         1. Implements a lazy OpenDir for extremely large directory
> >         listings.
> >         2. Avoids walking the entire directory when there is an exact
> >         filename match.
> > 
> > It's a little complicated, but I _really_ wanted to avoid disturbing the
> > logic in get_lanman2_dir_entry().
> 
> James, I hate you *so much* :-) :-) :-).

Well, next time we meet, you can slap me and storm off :)

> This is the code I promised
> myself I'd have fun writing this week after the CIFS conference...
> Now I just get to integrate yours instead :-( :-(.

Great! I wasn't positive I'd taken the right approach, because I thought
that maybe I was missing a peculiar reason for the allocation in
OpenDir(). Is there one?

> Thanks - this looks really good ! It won't make 3.0.6 as we've
> frozen that to get out asap but it should be in 3.0.7.

-- 
James Peach | jpeach at sgi.com | SGI Australian Software Group
I don't speak for SGI.