CVS update: samba/source/passdb

Jeremy Allison jra at samba.org
Tue Jul 1 17:01:15 GMT 2003


On Tue, Jul 01, 2003 at 12:40:52PM +0000, vlendec at samba.org wrote:
> 
> Date:	Tue Jul  1 12:40:52 2003
> Author:	vlendec
> 
> Update of /data/cvs/samba/source/passdb
> In directory dp.samba.org:/tmp/cvs-serv14092/passdb
> 
> Modified Files:
>       Tag: SAMBA_3_0
> 	secrets.c 
> Log Message:
> Fix two memory leaks. tdb_search_keys allocates space for the key
> strings.
> 
> Running 'net cache list' or secrets_get_trusted_domains through
> valgrind gives a *huge* amount of invalid reads of one byte beyond the
> indicated string length in libc's strncpy. Annoying...

We should replace these with strlcpy. Much more logical interface.

Jeremy.



More information about the samba-technical mailing list