CVS update: samba/source/passdb

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Jul 1 17:03:54 GMT 2003


On Tue, Jul 01, 2003 at 05:01:15PM +0000, Jeremy Allison wrote:
> > Running 'net cache list' or secrets_get_trusted_domains through
> > valgrind gives a *huge* amount of invalid reads of one byte beyond the
> > indicated string length in libc's strncpy. Annoying...
> 
> We should replace these with strlcpy. Much more logical interface.

As far as I can see from the Samba implementation this would also 
read over the non-null-terminated source string. It does a 

size_t = strlen(s)

Volker
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 240 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba-technical/attachments/20030701/9b90d324/attachment.bin


More information about the samba-technical mailing list