Printing is buggy under 2.2.3a + Win2KSP2.

[Gerald Carter]

On Thu, 21 Feb 2002, Anton N. Breusov wrote:

> Hi!
> 
> I have following problem:
> When I'm printing from Windows 2000 SP2 (Russian) clients
> (with or without SP2 Service Rollup package)
> to printer HP LJ 1100 connected to Samba server
> (FreeBSD 4.4-STABLE, Samba 2.2.3a, LprNG printing system, SPOOLSS enabled)
> than I can successfully print, upload or download
> printer drivers from/to clients, but cannot set
> special post-processing options such as "Print 4 pages in 1"
> zooming or even Paper orientation. For example, when I
> set options in Word printing window, then press "Close"
> and again open Printer Properties window all options are
> reset to default values. In 2.2.2 all seems working.
> I'm using latest Win2K printer drivers from HP.
> 
> I can send smb.conf contents or level 3 logs (very big ;-) )
> if neeeded.
> 
> Maybe this is new super-bug^H^H^Hsorry, feature introduces
> in this SP2SRP1 patches pack (it was installed almost at same time
> with Samba 2.2.3a upgrade)?

There's a bug in 2.2.3a that break devmode changes.  It's a one
line patch.  Attached.






cheers, jerry
 ---------------------------------------------------------------------
 Hewlett-Packard                                     http://www.hp.com
 SAMBA Team                                       http://www.samba.org
 --                                            http://www.plainjoe.org
 "Sam's Teach Yourself Samba in 24 Hours" 2ed.      ISBN 0-672-32269-2
 --"I never saved anything for the swim back." Ethan Hawk in Gattaca--
-------------- next part --------------
diff -u -r1.115.2.150 srv_spoolss_nt.c
--- rpc_server/srv_spoolss_nt.c	12 Feb 2002 15:21:04 -0000	1.115.2.150
+++ rpc_server/srv_spoolss_nt.c	12 Feb 2002 19:10:47 -0000
@@ -4800,7 +4814,7 @@
 		 * lookup previously saved driver initialization info, which is then
 		 * bound to the printer, simulating what happens in the Windows arch.
 		 */
-		if (strequal(printer->info_2->drivername, old_printer->info_2->drivername))
+		if (!strequal(printer->info_2->drivername, old_printer->info_2->drivername))
 			set_driver_init(printer, 2);
 	}