All known 2.2.1 showstoppers fixed..

[Jeremy Allison]

"John E. Malmberg" wrote:

> The nmbd bug I reported back when 2.2.0 was only a pre-alpha release
> does not appear to be fixed as of the June 27th 2001 CVS snapshot.
> 
> In module interface.c, routine interfaces_changed()
> 
> The routine get_interfaces() may return a negative value, and this
> is not checked before using the value returned in a following memcmp()
> routine.
> 
> This causes an access violation.
> 
> The code should be changed to:
> 
>       if ((n > 0) && (n != total_probed ||
>           memcmp(ifaces, probed_ifaces, sizeof(ifaces[0])*n))) {
>                 return True;
>       }

This code no longer exists in my 2.2 or HEAD sources so I
believe this is fixed.

Confirmation would help.....

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------