smbpasswd -ax error

[Herb Lewis]

The first test just tests to see that add user or delete user is set
it does not test for both being set. This looks like a bug. You 
probably need a third test of
((local__flags & (LOCAL_ADD_USER|LOCAL_DELETE_USER)) !=
 (LOCAL_ADD_USER|LOCAL_DELETE_USER))

Joe Meslovich wrote:
> 
> 
> Shouldn't smbpasswd fail in that instance because in the code there is the
> following test:
> 
>  /*
>          * Ensure add/delete user and either remote machine or join domain
> are
>          * not both set.
>          */
>         if((local_flags & (LOCAL_ADD_USER|LOCAL_DELETE_USER)) &&
> ((remote_machin
> e != NULL) || joining_domain)) {
>                 usage();
>         }
> 
> This is the proper behavior correct?
> 

-- 
======================================================================
Herb Lewis                               Silicon Graphics 
Networking Engineer                      1600 Amphitheatre Pkwy MS-510
Strategic Software Organization          Mountain View, CA  94043-1351
herb at sgi.com                             Tel: 650-933-2177
http://www.sgi.com                       Fax: 650-932-2177          
======================================================================