found crash bug in libsmb/clientgen.c

Luke Kenneth Casson Leighton lkcl at
Thu Jul 8 18:51:20 GMT 1999

i have fixed the problem in static cli_calc_session_pwds().  ideally i
would like to replace all instances where cli_session_setup() is called,
and cli_tcon_x() and cli_session_request() etc with
cli_establish_connection, and then remove cli_calc_session_pwds().


On Fri, 9 Jul 1999, Herb Lewis wrote:

> That is not the only call to cli_session_setup with potential problems.
> I see several that make calls similar to 
> cli_session_setup(&cli, "", "", 0, "", 0, "")
> And what about the next time someone adds some code? It might be better
> to create a new type for the pass and ntpass arguements and let the
> compilers catch new errors. The parameter should actually be pointing 
> to a 24 byte array not a generic char*
> -- 
> ======================================================================
> Herb Lewis                                   Silicon Graphics 
> Technical Marketing                          2011 N Shoreline Blvd
> Network Systems Division                     Mountain View, CA  94043  
> herb at                                 Tel: 650-933-2177
>                           Fax: 650-932-2177          
> ======================================================================

<a href="mailto:lkcl at"   > Luke Kenneth Casson Leighton    </a>
<a href=""> Samba and Network Development   </a>
<a href=""        > Samba Web site                  </a>
<a href=""      > Internet Security Systems, Inc. </a>

More information about the samba-technical mailing list