found crash bug in libsmb/clientgen.c

Luke Kenneth Casson Leighton lkcl at switchboard.net
Thu Jul 8 18:51:55 GMT 1999


On Fri, 9 Jul 1999, Herb Lewis wrote:

> That is not the only call to cli_session_setup with potential problems.
> I see several that make calls similar to 
> 
> cli_session_setup(&cli, "", "", 0, "", 0, "")
> 
> And what about the next time someone adds some code? It might be better
> to create a new type for the pass and ntpass arguements and let the
> compilers catch new errors. The parameter should actually be pointing 
> to a 24 byte array not a generic char*

... actually, due to the ntlmv2 code the ntpasswd can be variable length
:-)



More information about the samba-technical mailing list