found crash bug in libsmb/clientgen.c

Herb Lewis herb at
Thu Jul 8 14:23:21 GMT 1999

That is not the only call to cli_session_setup with potential problems.
I see several that make calls similar to 

cli_session_setup(&cli, "", "", 0, "", 0, "")

And what about the next time someone adds some code? It might be better
to create a new type for the pass and ntpass arguements and let the
compilers catch new errors. The parameter should actually be pointing 
to a 24 byte array not a generic char*
Herb Lewis                                   Silicon Graphics 
Technical Marketing                          2011 N Shoreline Blvd
Network Systems Division                     Mountain View, CA  94043  
herb at                                 Tel: 650-933-2177                           Fax: 650-932-2177          

More information about the samba-technical mailing list