[PATCH] --link-dest option
jw at pegasys.ws
Fri Mar 22 15:58:45 EST 2002
On Thu, Mar 21, 2002 at 07:44:34PM -0800, Martin Pool wrote:
> On 21 Mar 2002, jw schultz <jw at pegasys.ws> wrote:
> > Please CC me. I'm not subscribed.
> > Attached is a patch against 2.5.4pre1 CVS current to add the
> > --link-dest option so rsync will create hardlinks for
> > unchanged regular files to a directory on the destination.
> > This is like --compare-dest except that the result is not a
> > sparse tree.
> That's really good, thankyou.
> I think we should merge this, but not right now because we need
> to stabilize 2.5. I will put it in the patches/ directory.
Understood. The POPT stuff at least is a moving target.
My primary concern is that at some point i can say "use
version x.y or greater"
> > Also included is extension to --(ex|in)clude-from to allow -
> > for stdin.
> It's somewhat better if you send each patch in a separate email,
> in case people want to merge one but not the other. Of course
> in this case it's pretty trivial to split them, and I don't
> see any reason not to take both.
Generally, i agree. The stdin stuff was more like a crumb.
Trivial to isolate but so obviously corect.
> If you have time, it would be really excellent if you could
> write a test case for the new features, based on the existing
> ones in testsuite/
I'm looking at testsuite now. A regression test is
desireable, especially to make sure that the linked from
tree doesn't get modified. With checkit and the surrounding
complexity it is no wonder --compare-dest doesn't have a
test case either. I'll make no promises.
J.W. Schultz Pegasystems Technologies
email address: jw at pegasys.ws
Remember Cernan and Schmitt
More information about the rsync