[cifs:for-next 13/14] fs/smb/client/cifs_debug.c:167:1: warning: label at end of compound statement is a C2x extension
Shyam Prasad N
nspmangalore at gmail.com
Mon Jun 26 05:33:59 UTC 2023
On Sun, Jun 25, 2023 at 9:11 PM Steve French <smfrench at gmail.com> wrote:
>
> Updated Shyam's patch to address this and a sparse warning and a
> checkpatch warning
>
>
> On Sun, Jun 25, 2023 at 2:14 AM kernel test robot <lkp at intel.com> wrote:
> >
> > tree: git://git.samba.org/sfrench/cifs-2.6.git for-next
> > head: d75e841ced93ce9cd86dc46b8a9453241dcbc61b
> > commit: 33bc5dec2b4fd8d00fed51183615d91badf607d6 [13/14] cifs: display the endpoint IP details in DebugData
> > config: hexagon-randconfig-r045-20230625 (https://download.01.org/0day-ci/archive/20230625/202306251539.R34e3RXd-lkp@intel.com/config)
> > compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
> > reproduce: (https://download.01.org/0day-ci/archive/20230625/202306251539.R34e3RXd-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp at intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202306251539.R34e3RXd-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> > In file included from fs/smb/client/cifs_debug.c:15:
> > In file included from include/uapi/linux/ethtool.h:19:
> > In file included from include/linux/if_ether.h:19:
> > In file included from include/linux/skbuff.h:17:
> > In file included from include/linux/bvec.h:10:
> > In file included from include/linux/highmem.h:12:
> > In file included from include/linux/hardirq.h:11:
> > In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> > In file included from include/asm-generic/hardirq.h:17:
> > In file included from include/linux/irq.h:20:
> > In file included from include/linux/io.h:13:
> > In file included from arch/hexagon/include/asm/io.h:334:
> > include/asm-generic/io.h:547:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 547 | val = __raw_readb(PCI_IOBASE + addr);
> > | ~~~~~~~~~~ ^
> > include/asm-generic/io.h:560:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 560 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
> > | ~~~~~~~~~~ ^
> > include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
> > 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
> > | ^
> > In file included from fs/smb/client/cifs_debug.c:15:
> > In file included from include/uapi/linux/ethtool.h:19:
> > In file included from include/linux/if_ether.h:19:
> > In file included from include/linux/skbuff.h:17:
> > In file included from include/linux/bvec.h:10:
> > In file included from include/linux/highmem.h:12:
> > In file included from include/linux/hardirq.h:11:
> > In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> > In file included from include/asm-generic/hardirq.h:17:
> > In file included from include/linux/irq.h:20:
> > In file included from include/linux/io.h:13:
> > In file included from arch/hexagon/include/asm/io.h:334:
> > include/asm-generic/io.h:573:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 573 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
> > | ~~~~~~~~~~ ^
> > include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
> > 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
> > | ^
> > In file included from fs/smb/client/cifs_debug.c:15:
> > In file included from include/uapi/linux/ethtool.h:19:
> > In file included from include/linux/if_ether.h:19:
> > In file included from include/linux/skbuff.h:17:
> > In file included from include/linux/bvec.h:10:
> > In file included from include/linux/highmem.h:12:
> > In file included from include/linux/hardirq.h:11:
> > In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> > In file included from include/asm-generic/hardirq.h:17:
> > In file included from include/linux/irq.h:20:
> > In file included from include/linux/io.h:13:
> > In file included from arch/hexagon/include/asm/io.h:334:
> > include/asm-generic/io.h:584:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 584 | __raw_writeb(value, PCI_IOBASE + addr);
> > | ~~~~~~~~~~ ^
> > include/asm-generic/io.h:594:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 594 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
> > | ~~~~~~~~~~ ^
> > include/asm-generic/io.h:604:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> > 604 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
> > | ~~~~~~~~~~ ^
> > >> fs/smb/client/cifs_debug.c:167:1: warning: label at end of compound statement is a C2x extension [-Wc2x-extensions]
> > 167 | }
> > | ^
> > 7 warnings generated.
> >
> >
> > vim +167 fs/smb/client/cifs_debug.c
> >
> > 33bc5dec2b4fd8 fs/smb/client/cifs_debug.c Shyam Prasad N 2023-06-09 166
> > 85150929a15b4e fs/cifs/cifs_debug.c Aurelien Aptel 2019-11-20 @167 }
> > 85150929a15b4e fs/cifs/cifs_debug.c Aurelien Aptel 2019-11-20 168
> >
> > :::::: The code at line 167 was first introduced by commit
> > :::::: 85150929a15b4e0a225434d5970bba14ebdf31f1 cifs: dump channel info in DebugData
> >
> > :::::: TO: Aurelien Aptel <aaptel at suse.com>
> > :::::: CC: Steve French <stfrench at microsoft.com>
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
>
>
>
> --
> Thanks,
>
> Steve
Thanks Steve.
The changes look good to me.
--
Regards,
Shyam
More information about the samba-technical
mailing list