[PATCH] Fix server side DRSUAPI_DRS_GET_ANC handling (bug #12398)
Stefan Metzmacher
metze at samba.org
Fri Dec 9 09:38:45 UTC 2016
Hi Andrew,
>>> I think having more detailed tests and get the 100% exact behavior
>>> as
>>> Windows
>>> is desired, but a major effort.
>>
>> I want to see shown that:
>> - additional objects are added to the reply
>> - that they are non-critical
>> - that they are added in a reasonable order (doens't need to be
>> exactly what windows does, but needs to be reasonable).
>> - In particular that a paternity sequence of critical -> non-
>> critical
>> -> critical is handled correctly.
>>
>> Replication bugs bite us pretty hard, as you have seen in my changes
>> here, I do want them very well tested.
>
> I know quite how busy you are, so after the great work he has done on
> DNS testing, I have asked Bob to make a start on the tests required
> here. It should be a good introduction to the guts of GetNCChanges ;-)
>
> I hope that helps move this task forward.
Thanks!
I've already started with it. See
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-fix
This adds a test as source4/torture/drs/python/getnc.py
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=3a3b8a5f3a5f337561b9852a371db222917d2cc6
But I guess it should be somehow merged with
source4/torture/drs/python/getnc_exop.py
While the tests show that it's not 100% correct,
we're using the following patch in our packages
to avoid the problems with joining new servers:
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=193b08f0b096dba4798fc04ef9b0d6081fd1e1ec
Maybe Bob can go on from there.
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20161209/2f013b6c/signature.sig>
More information about the samba-technical
mailing list