[PATCH] Fix server side DRSUAPI_DRS_GET_ANC handling (bug #12398)

[Andrew Bartlett]

On Thu, 2016-12-01 at 07:25 +1300, Andrew Bartlett wrote:
> On Wed, 2016-11-30 at 09:28 +0100, Stefan Metzmacher wrote:
> 
> That would be a good way to show the overall result, but we need a
> test
> of the GetNCChanges call.  
> 
> It would probably be best in that getnc_exop.py or similar.
> 
> > 
> > I think having more detailed tests and get the 100% exact behavior
> > as
> > Windows
> > is desired, but a major effort.
> 
> I want to see shown that:
>  - additional objects are added to the reply
>  - that they are non-critical
>  - that they are added in a reasonable order (doens't need to be
> exactly what windows does, but needs to be reasonable).
>  - In particular that a paternity sequence of critical -> non-
> critical
> -> critical is handled correctly.
> 
> Replication bugs bite us pretty hard, as you have seen in my changes
> here, I do want them very well tested. 

I know quite how busy you are, so after the great work he has done on
DNS testing, I have asked Bob to make a start on the tests required
here.  It should be a good introduction to the guts of GetNCChanges ;-)

I hope that helps move this task forward.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba