[PATCH] File Server Remote VSS Protocol server

[David Disseldorp]

On Thu, 19 Mar 2015 16:47:03 -0700, Jeremy Allison wrote:

> > >   git://git.samba.org/ddiss/samba.git fsrvp_srv  
> > 
> > Did anyone get a chance to start looking at this?  
> 
> First comment I've found (this *really* is good...).
> 
> +       become_root();
> +       ret = ioctl(dest_fd, BTRFS_IOC_SNAP_CREATE_V2, &ioctl_arg);
> +       unbecome_root();
> +       if (ret < 0) {
> +               DEBUG(0, ("%s -> %s(%s) BTRFS_IOC_SNAP_CREATE_V2 failed: %s\n",
> +                         base_volume, dest_path, dest_subvolume,
> +                         strerror(errno)));
> +               status = map_nt_error_from_unix(errno);
> 
> You need to save off errno inside of the become_root()/unbecome_root();
> pairs if you want to examine it later, as this can change errno in the
> unbecome_root() code path.

Good catch. I'll fix these and resend after you're done with the
first pass.

> Still looking. Should be finished with the first pass over it
> tomorrow sometime.

Thanks for the review Jeremy, I very much appreciate it.

Cheers, David