[PATCH] File Server Remote VSS Protocol server

[Jeremy Allison]

On Mon, Mar 16, 2015 at 04:33:36PM +0100, David Disseldorp wrote:
> On Mon, 9 Mar 2015 20:45:47 +0100, David Disseldorp wrote:
> 
> > The following changes since commit f5d0204bfa1eb641fe7697613c1f773b6a7e65de:
> > 
> >   s3-winbind: Fix chached user group lookup of trusted domains. (2015-03-09 19:23:25 +0100)
> > 
> > are available in the git repository at:
> > 
> >   git://git.samba.org/ddiss/samba.git fsrvp_srv
> 
> Did anyone get a chance to start looking at this?

First comment I've found (this *really* is good...).

+       become_root();
+       ret = ioctl(dest_fd, BTRFS_IOC_SNAP_CREATE_V2, &ioctl_arg);
+       unbecome_root();
+       if (ret < 0) {
+               DEBUG(0, ("%s -> %s(%s) BTRFS_IOC_SNAP_CREATE_V2 failed: %s\n",
+                         base_volume, dest_path, dest_subvolume,
+                         strerror(errno)));
+               status = map_nt_error_from_unix(errno);

You need to save off errno inside of the become_root()/unbecome_root();
pairs if you want to examine it later, as this can change errno in the
unbecome_root() code path.

Still looking. Should be finished with the first pass over it
tomorrow sometime.

Really good David, really good !

I know of at least one NAS vendor who ships btrfs who will
want to kiss your ring once this gets in :-) :-).

Jeremy.