domain/domainDNS

[Andrew Bartlett]

Tridge,

I was looking at your new samdb_domain_sid() function and I wondered why
in your search:

/* find the domain_sid */
domain_sid = samdb_search_dom_sid(ldb, tmp_ctx, basedn, 
				  "objectSid", "objectClass=domainDNS");

You look for objectClass=domainDNS.  I realise that the objectClass
restriction should avoid silly errors, but why not objectClass=domain?  

The reason I suggest this is that for certain standalone/domain member
and possible NT4-downlevel operations, we might not have a domainDNS at
all. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Student Network Administrator, Hawker College  http://hawkerc.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.samba.org/archive/samba-technical/attachments/20051227/4a8dfcfc/attachment.bin