[Samba] ceph is disabled even if explicitly asked to be enabled

[Michael Tokarev]

31.07.2024 09:38, Anoop C S via samba wrote:
> On Wed, 2024-07-31 at 08:36 +0300, Michael Tokarev via samba wrote:

>> The problem is that ceph is disabled by configure even if it is
>> explicitly enabled by the command-line switch.  Configure should fail
>> here instead of continuing, - *that* is the problem.
> 
> This is/was always the situation because building vfs_ceph is enabled
> by default. Therefore an explicit '--enable-cephfs' doesn't end up as [...]

> May be we could rethink on the current behaviour which silently disable
> building the module when requirements are not met. But keep in mind
> that this silent approach existed all this while if either libcephfs or
> related dependencies(acl support) were not present during build
> process. It is also an option to switch the default from 'True' to
> 'False' so that failing at configure stage is much more meaningful.

In most other auto-configuration systems out there, there's a 3rd value
for any option besides true and false, - like "auto", to mean auto-
detect.  So by default it is set to "auto" and the end result depends
whenever the required dependencies are present or not.  If enabled
explicitly (=true), configure fails if it can't find the needed deps
(and if disabled, no deps are checked).

This looks like a noticeable omission in samba configure/build system,
if it doesn't understand the 3rd case of "auto".

I always explicitly enable certain features for debian builds of various
packages, to ensure the required features are actually being built.
In this case I used --enable-cephfs as usual and thought it will force-
enable ceph (or fail if something is wrong).  I only noticed it because
just recently I created a separate package for vfs_ceph, and it is being
empty (missing files), -- before, I had vfs/*.so for file list and didn't
check if ceph.so is here or not, thinking it is due to explicit --enable.

But it looks like this is a more general issue than ceph.

Thanks,

/mjt