[Samba] 4.21-rc: new symbols form appeared

[Michael Tokarev]

31.07.2024 08:32, Douglas Bagnall wrote:
> On 31/07/24 17:07, Jo Sutton wrote:
>> On 30/07/24 9:00 pm, Michael Tokarev via samba wrote:
>>> I'm trying to build 4.21-rc packages for debian, and noticed
>>> that a new form of version info symbol appeared (only tried
>>> tdb for now).  In addition to usual
>>>
>>>   TDB.1.4.11 at TDB.1_4.11
>>>
>>> symbol, it now also adds
>>>
>>>   TDB_1_4_11 at TDB_1_4_11
>>>
>>> (with dots replaced with underscores), but for single version
>>> only.
>>
>> I suspect this is related to commit 0bc5b6f29307ce758774c1b2f48ce62315fdc7f9 (and https://bugzilla.samba.org/show_bug.cgi?id=15673). But I couldn’t 
>> say whether the new symbol is correct or not.
> 
> Oh.
> 
> Would r'[^.\w]' in the re.sub() be right?
> 
> Or are there other characters other than '.' and numbers and letters that we need to preserve?
> 
> Or do we need to treat version and libname differently?

Actually this looks like something else.

Yes, the new form appears to be due to this commit.

However, the fact that only the last symbol is "doubled" suggests
that the last version is added explicitly somewhere, in addition
to all the other versions already in there (or else we'd have
*all* versions doubled, not just the last one).  So it looks like
we should drop the extra version symbol generation entirely, -
the one which uses this new regex, - and keep the regular set
generated from the ABI files.

Thanks,

/mjt