[Samba] Win7 clients problem after upgrading samba file server to 4.12 on Arch

[Rowland penny]

On 09/05/2020 08:38, pavlos via samba wrote:
> Hi Volker, Jermey, and the Community,
>
> To be clear: I didn't analyze your code, I don't know structures of Samba,
> definitely I am not a person to judge and blame anybody :)
> I am sure that there were reasons, you wanted to clarify some issues around
> controlling share mode flags. And it's rather everything OK with your code.
>
> Even more: most probably your change revealed a bug in Win7, that has been
> fixed by Microsoft in later Win editions.
> Because I have no problems when accessing my Samba shares from Win10
> computer, android devices or other linux systems.
>
> My recommendation is as follows: after you double check your code, please
> make it user-configurable - I mean a configuration parameter dedicated to
> people using Win7-like versions in their networks, the parameter which by
> default uses your enhancements, but may be switched off to bypass your code
> in such special cases like mine.
>
> I will be more than happy to help you in testing any change you decide to
> apply.
>
> Kind regards,
> Pawel.

I cannot see making it user configurable for Window 7 happening, mainly 
because Windows 7 is EOL and Windows wants you to upgrade. Not that this 
has anything to do with us, but do we really want to fix this, when, by 
your own admission, it is fixed in supported versions of Windows ?

Rowland