[Samba] The Recycled PIDs Fix

[Manoj Dahal]

** Low Priority **

Hi,
 
I have made the changes suggested by Stefan. The patch is available at https://bugzilla.samba.org/show_bug.cgi?id=8760#c6.
 
Please send your review comments.
 
Thanks,
 
-Manoj

>>> Manoj Dahal 2/13/2012 5:00 PM >>>
Hi Volker/Stefan,
 
As per this discussion I have created a bug#8760 and I have attached
a patch for the proposed fix in https://bugzilla.samba.org/show_bug.cgi?id=8760#c3.
 
Is it possible for you to review the changes and give comments? When tested with the changes
I have found that the share mode entries added by NCP server are no more wiped out by smbd.
 
 
Thanks,
 
-Manoj
 
>>> Volker Lendecke <Volker.Lendecke at SerNet.DE> 1/25/2012 8:21 PM >>>
On Wed, Jan 25, 2012 at 03:47:58PM +0100, Stefan (metze) Metzmacher wrote:
> Hi Manoj,
> 
> > This is regarding your fix on recycled PIDs. I am an NCP developer from Novell and we use libsmbsharemodes library
> > from Samba for Cross Protocols Locks between NCP, Samba and others. I have few queries regarding your fix.
> >  
> > In your fix, you have added a new field called 'unique_id' in the server_id structure 
> > and we need to pass this in our call to samba share mode APIs  e.g. create_share_mode_entry().
> >  
> > Also, you have introduced server registration/de-registration which is associated with 'unqiue_id'. If we use these new APIs 
> > then in which library from Samba do we need to link to?  Or without calling serverid_register() can we directly pass any 'unique_id'
> > while calling to create_share_mode_entry() and in that case whether this and other share mode APIs will work properly?
> >  
> >  
> > Looking forward to your answer,
> 
> Maybe we could invent a special value e.g. UINT64_MAX as "don't verify
> this unique id".

Good idea. Did not think about that. This would assume that
the ncp server process never dies...

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de