[Samba] smbd processes never go away

[Jeremy Allison]

On Wed, Nov 02, 2005 at 04:18:42PM -0500, Fenn_Rider at IDX.COM wrote:
> I am having a problem with Samba 3.0.20b runninn on Fedora core 4,  with a 
>  2.6.11-1.1369_FC4smp kernel. Each time I open a connection a new smbd 
> process is forked. That is fine, but then that process never goes away, 
> even after the client has disconnected. Even though there are only a few 
> clients who make an smb connection to the server in question, dozens and 
> dozens of smbd processes are getting started and not going away.  When the 
> new smbd process appears, at first it show us up as being run by the 
> client, but when the client disconnects, that same smbd processes appears 
> under root's name. 
> 
> Anyone else experiencing this?

Can you try this patch that Jerry recently added into 3.0.x ?

Thanks,

	Jeremy.
-------------- next part --------------
Author: jerry
Revision: r11292
Modified: source/rpc_server/srv_pipe_hnd.c /trunk/source/rpc_server/srv_pipe_hnd.c
Added: 
Removed: 


Missed merge from Samba 2.2 many years ago....

Don't count open pipes in the num_files_open on a connection.
conn_idle_all() handles this by looking for open rpc handles
If there are no open handles, we can close the IPC$ share.


Index: source/rpc_server/srv_pipe_hnd.c
===================================================================
--- source/rpc_server/srv_pipe_hnd.c	(revision 11291)
+++ source/rpc_server/srv_pipe_hnd.c	(revision 11292)
@@ -337,9 +337,6 @@
 
 	p->conn = conn;
 
-	/* Ensure the connection isn't idled whilst this pipe is open. */
-	p->conn->num_files_open++;
-
 	p->vuid  = vuid;
 
 	p->endian = RPC_LITTLE_ENDIAN;
@@ -1156,8 +1153,6 @@
 
 	DLIST_REMOVE(InternalPipes, p);
 
-	p->conn->num_files_open--;
-
 	ZERO_STRUCTP(p);
 
 	SAFE_FREE(p);