[Samba] Re: exclude_dir option for VFS recycle module

[Kevin Kobb]

Kevin Kobb wrote:
> Hello all,
> 
> I am testing the VFS recycle module, and have a question.
> 
> The module is working the way I hoped with the exception of the
> exclude_dir option. I have an entry like:
> exclude_dir = dir1  -- files I place in dir1 are not sent to the recycle
> location. However, if I have a folder beneath dir1 like dir1/dir2, files
> in dir2 get sent to the recycle location. I've tried using wildcards in
> my smb.conf like exclude_dir = dir1/*, exclude_dir = dir1*, and other
> combinations, but still can't get it to work.
> 
> Can somebody advise me if this is an intended mode of operation, a bug,
> or a configuration error on my part?
> 
> I am using Samba 3.12 on 5.3-RELEASE-p6.
> 
> Thanks.
> 

OK, may have found my answer. Found the following in vfs_recycle.c:

/* FIXME: this check will fail if we have more than one level of
directories,
* we shoud check for every level 1, 1/2, 1/2/3, 1/2/3/4 ....
*      ---simo
*/
        if (checkparam(recycle_exclude_dir(handle), path_name)) {
                DEBUG(3, ("recycle: directory %s is excluded \n", 	
                        path_name));
                rc = SMB_VFS_NEXT_UNLINK(handle, conn, file_name);
                goto done;
        }