[Samba] Two bugs in 3.0.x code not in 2.2.8!

[Werner]

These two bugs exist in 3.0.0, 3.0.1 and in 3.0.2pre1.  They do not 
exist in 2.2.8.  

This bug affects Linux 2.4.21 and 2.6.1 and Solaris 9

After running configure, a (gnu)make -j X no longer works to perform 
parallel compiles.

It errors out after smbd/files.c.  It looks like the dependencies may not 
be correct for parallel makes.

This bug affects Linux 2.4.21 and 2.6.1.  It does not seem to affect Solaris.

When double clicking on a folder, it takes a long time to open the 
folder, even with only a file or two in that folder.  A long time is 5-10 
seconds.
Also, if you click on a file, move it a little bit with the mouse, then 
click on another file, it will be 5-10 seconds before the next file is 
highlighted.  

Interestingly enough, this is NOT occuring during copies.  Once the file 
is selected and dragged for copy, the copy is not missing ACKs.

a tcpdump shows ACK packets getting dropped in both directions, for some 
reason.  Clients tested are Windows XP and NT.  This behaviour is only 
occuring in the 3.0.x code tree on Linux, both 2.6.0 kernels and 2.4.21.  
It is not happening with 2.2.8 Samba.

In the below tcpdump output, phantom is the client and vampire is the 
Samba server.

16:09:40.274622 phantom..1931 > vampire..netbios-ssn: P 99039:99291(252) ack 11056688 win 63727 NBT Packet (DF)
16:09:40.314331 vampire..netbios-ssn > phantom..1931: . ack 99291 win 12864 (DF)
16:09:44.425623 vampire..netbios-ssn > phantom..1931: P 11056688:11056810(122) ack 99291 win 12864 NBT Packet (DF)
16:09:44.426174 phantom..1931 > vampire..netbios-ssn: P 99291:99375(84) ack 11056810 win 63605 NBT Packet (DF)

16:09:44.465653 phantom..1931 > vampire..netbios-ssn: P 100924:101176(252) ack 11058511 win 63441 NBT Packet (DF)
16:09:44.505522 vampire..netbios-ssn > phantom..1931: . ack 101176 win 12864 (DF)
16:09:48.616503 vampire..netbios-ssn > phantom..1931: P 11058511:11058633(122) ack 101176 win 12864 NBT Packet (DF)
16:09:48.617100 phantom..1931 > vampire..netbios-ssn: P 101176:101260(84) ack 11058633 win 63319 NBT Packet (DF)

16:09:50.374161 phantom..1931 > vampire..netbios-ssn: P 122535:122615(80) ack 14799792 win 63859 NBT Packet (DF)
16:09:50.552663 phantom..1931 > vampire..netbios-ssn: . ack 14802479 win 64201 (DF)
16:09:52.238184 phantom..1931 > vampire..netbios-ssn: P 125122:125202(80) ack 14802479 win 64201 NBT Packet (DF)
16:09:52.238323 vampire..netbios-ssn > phantom..1931: P 14802479:14802583(104) ack 125202 win 12864 NBT Packet (DF)

16:09:56.363392 phantom..1931 > vampire..netbios-ssn: P 150497:150749(252) ack 18535074 win 63265 NBT Packet (DF)
16:09:56.403210 vampire..netbios-ssn > phantom..1931: . ack 150749 win 12864 (DF)
16:10:00.513148 vampire..netbios-ssn > phantom..1931: P 18535074:18535196(122) ack 150749 win 12864 NBT Packet (DF)
16:10:00.513684 phantom..1931 > vampire..netbios-ssn: P 150749:150833(84) ack 18535196 win 63143 NBT Packet (DF)

16:10:05.594342 vampire..netbios-ssn > phantom..1931: P 22299511:22299550(39) ack 172657 win 12864 NBT Packet (DF)
16:10:05.739857 phantom..1931 > vampire..netbios-ssn: . ack 22302237 win 63739 (DF)
16:10:07.222591 phantom..1931 > vampire..netbios-ssn: P 175244:175324(80) ack 22302237 win 63739 NBT Packet (DF)
16:10:07.222721 vampire..netbios-ssn > phantom..1931: P 22302237:22302341(104) ack 175324 win 12864 NBT Packet (DF)

16:10:07.433092 vampire..netbios-ssn > phantom..1931: P 22303291:22303330(39) ack 176309 win 12864 NBT Packet (DF)
16:10:07.433486 phantom..1931 > vampire..netbios-ssn: . ack 22303330 win 64201 (DF)
16:10:10.608561 phantom..1931 > vampire..netbios-ssn: P 176309:176354(45) ack 22303330 win 64201 NBT Packet (DF)

I would be happy to provide more details if required.

Thanks...