[Samba] smbd 2.2.2 code changes

BYRNES,MICHAEL (HP-NewJersey,ex1) michael_byrnes at hp.com
Fri Feb 15 11:20:11 GMT 2002


Hi folks,
want to share chgs made to the 2.2.2 smbd code to:
 1. fix a silent ACL setting failure (posix_acls.c.diff)
 2. enh the SID to user mapping when setting ACL's (passdb.c.diff)

The former just looks to be a misplaced return code check 
of unpack_canon_ace() in set_nt_acl().

The later is a means of getting a SID-to-name mapping in
local_sid_to_uid() when a local SID lookup fails. In this
case a call is made to the PDC asking for a SID-to-name.
If successfull it then:
 1. passes the name to getpwname() if that fails it
 2. passes the name to the adduser_script for creation, and retries #1.

Also, wasn't quite sure what pdb_rid_is_user() was doing WRT lower
bit and USER_RID_TYPE, so moving that routine to the bottom of
local_sid_to_uid()
took care of our problem for certain USER RID's being rejected.

Regards,
Mike Byrnes
michael_byrnes at hp.com

 <<posix_acls.c.diff>>  <<passdb.c.diff>>  <<Makefile.in.diff>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: posix_acls.c.diff
Type: application/octet-stream
Size: 850 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba/attachments/20020215/06822bb0/posix_acls.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: passdb.c.diff
Type: application/octet-stream
Size: 3149 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba/attachments/20020215/06822bb0/passdb.c.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Makefile.in.diff
Type: application/octet-stream
Size: 1653 bytes
Desc: not available
Url : http://lists.samba.org/archive/samba/attachments/20020215/06822bb0/Makefile.in.obj


More information about the samba mailing list