Bug found: Truncation of files during multiple simultaneous logons ....

Jeremy Allison jallison at whistle.com
Tue Feb 10 23:04:05 GMT 1998

Ravi Subramaniam wrote:
> Hi Samba Team,
> There seems to be a bug that seems to have survived from 1.9.16p11 (that is
> as far as I went). BTW, 1.9.15p8 does not have this bit of code.
> ...... explaination deleted...
>         - I think that this can be fixed by modifying the 'if' comparison to be
> done on 'vuid' and not 'uid'.
> Finally, a question:
> What was the motivation for putting in this code in the first place ? A
> possible scenario that comes to mind is when the client dies abnormally 
> but ... does the client sends a ulogoff at this
> time ?


	*Wonderful* piece of debugging - congratulations
and thanks !

The fix of comparing with the vuid is correct, and
the problem in ulogoff was missed when I invented 
the and coded up the vuid construct (when I was fixing 
an earlier bug where Samba used to send the users uid 
directly as the vuid).

The code is there to comply with the SMB spec that
states when a ulogoff is done that all files opened
by that vuid must be closed.

Thanks once again for your help, I'll fix this


	Jeremy Allison,
	Samba Team.

Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba mailing list