patches to move ksmbd and cifs under new subdirectory

Steve French smfrench at
Tue May 23 06:39:07 UTC 2023

On Mon, May 22, 2023 at 12:33 PM Linus Torvalds
<torvalds at> wrote:
> On Mon, May 22, 2023 at 9:33 AM Steve French <smfrench at> wrote:
> >
> > Following up on the email thread suggestion to move fs/ksmbd and
> > fs/cifs and fs/smbfs_common all under a common directory fs/smb, here
> > is an updated patchset for that (added one small patch).
> Looks fine to me.
> I wouldn't have noticed the typo that Tom Talpey mentioned (misspelled
> "common" in the commit message of the first patch), and that
> SMB_CLIENT config variable is odd.
> I'm actually surprised that Kconfig didn't complain about the
>         select SMB_CLIENT
> when there is no actual declaration of that Kconfig variable, just a random use.
> That thing seems confusing and confused, and isn't related to the
> renaming, so please drop the new random SMB_CLIENT config variable. If
> you want to introduce a new Kconfig variable later for some reason,
> that's fine, but please don't mix those kinds of changes up with pure
> renames.

I have removed CONFIG_SMB_CLIENT (and fixed the spelling typo in the comment).
Updated patch 1 attached (the other two are unchanged).

My reason for adding CONFIG_SMB_CLIENT, enabling CONFIG_SMB_CLIENT
when CONFIG_CIFS was enabled, I was trying to make the Makefile more clear
(without changing any behavior):

e.g. this seemed less confusing
+++ b/fs/smb/Makefile
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_SMBFS)            += common/
+obj-$(CONFIG_SMB_CLIENT)      += client/
+obj-$(CONFIG_SMB_SERVER)       += server/

instead of

+++ b/fs/smb/Makefile
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_SMBFS)         += common/
+obj-$(CONFIG_CIFS)             += client/
+obj-$(CONFIG_SMB_SERVER)       += server/


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smb-move-client-and-server-files-to-common-directory.patch
Type: text/x-patch
Size: 42837 bytes
Desc: not available
URL: <>

More information about the samba-technical mailing list