[PATCH RFC] s3: smbd: Consistently map EAs to user namespace

Jeremy Allison jra at samba.org
Tue Sep 27 21:58:36 UTC 2022

On Wed, Sep 28, 2022 at 10:53:19AM +1300, Andrew Bartlett wrote:
>On Tue, 2022-09-27 at 14:45 -0700, Jeremy Allison wrote:
>> On Wed, Sep 28, 2022 at 10:37:41AM +1300, Andrew Bartlett via samba-
>> technical wrote:
>> > I honestly can't think of a way out of this that doesn't break
>> > something.
>> What would it break ?
>Perhaps I spoke too strongly, what I meant was be a user-visible
>change, that could potentially break some unknown user.

Yes, true. But as below, I think the original code
exposing non-user EA's was the real bug. My fault
of course, as are most design errors in Samba :-).

>> What am I missing ? Under what circumstances would an
>> SMB3 client get or set a non-user namespace EA ?
>We are in agreement.  What I'm saying is that it seems to be a mistake,
>which can be observed externally, to have mapped other namespaces by
>simply stripping a prefix.

Yes ! +1. Exposing other namespaces was the original
bug. IMHO we should fix for 4.18.0 and announce now
this change is coming.

If someone *really* depends on this, we could have
an option to keep the original behavior.

But I really don't want to (add that option, that
is :-).

More information about the samba-technical mailing list