[PATCH RFC] s3: smbd: Consistently map EAs to user namespace

[Andrew Bartlett]

On Tue, 2022-09-27 at 14:45 -0700, Jeremy Allison wrote:
> On Wed, Sep 28, 2022 at 10:37:41AM +1300, Andrew Bartlett via samba-
> technical wrote:
> > I honestly can't think of a way out of this that doesn't break
> > something.
> 
> What would it break ?

Perhaps I spoke too strongly, what I meant was be a user-visible
change, that could potentially break some unknown user. 

> > Mapping the EAs from multiple namespaces by stripping the prefix
> > really
> > seems to be a bad idea - if only because information is lost.
> 
> See below. I don't think incoming EA's from SMB3 clients have
> a namespace - just make the always user.
> 
> > Also, I just don't see what business a windows client would have in
> > reading the non-user EAs, and if a client should read them they
> > should
> > be read in their own namespace.
> 
> As EA's from Windows clients don't have a namespace prefix
> by default, they are always (or should be) mapped to the
> user. namespace on UNIX.
> 
> What am I missing ? Under what circumstances would an
> SMB3 client get or set a non-user namespace EA ?

We are in agreement.  What I'm saying is that it seems to be a mistake,
which can be observed externally, to have mapped other namespaces by
simply stripping a prefix.  

Andrew,

-- 
Andrew Bartlett (he/him)       https://samba.org/~abartlet/
Samba Team Member (since 2001) https://samba.org
Samba Team Lead, Catalyst IT   https://catalyst.net.nz/services/samba

Samba Development and Support, Catalyst IT - Expert Open Source 
Solutions