4.12 -> 4.13 upgrade

[Rowland penny]

On 22/10/2020 11:08, L.P.H. van Belle via samba-technical wrote:
>   
>
>> -----Oorspronkelijk bericht-----
>> Van: samba-technical
>> [mailto:samba-technical-bounces at lists.samba.org] Namens
>> Rowland penny via samba-technical
>> Verzonden: donderdag 22 oktober 2020 12:00
>> Aan: samba-technical at lists.samba.org
>> Onderwerp: Re: 4.12 -> 4.13 upgrade
>>
>> On 22/10/2020 10:06, L. van Belle via samba-technical wrote:
>>> Hai,
>>>
>>> Small question, i cant find this.
>>>
>>> So after the 4.13.0 (on
>>> release date) I upgrade a DC and that failed. so i reverted
>> back to my VM
>>> snapshot.
>>>
>>> I now see the following in the logs.
>>>
>>> [2020/10/22 10:48:36.514438,
>>>    0] ../../lib/util/util_runcmd.c:352(samba_runcmd_io_handler)
>>>
>>>    /usr/sbin/samba_dnsupdate: /usr/sbin/samba_dnsupdate:274:
>>> DeprecationWarning: please use
>> dns.resolver.Resolver.resolve() instead
>>> [2020/10/22 10:48:36.521212,
>>>    0] ../../lib/util/util_runcmd.c:352(samba_runcmd_io_handler)
>>>
>>>    /usr/sbin/samba_dnsupdate:
>>>
>>>    return resolver.query(name, name_type)
>>>
>>> Now, when i
>>> look at DC2, which stayed at 4.12.8, that one is not showing any
>>> DeprecationWarnings.
>>>
>>> And i recently added a 3th DC with 4.12.8 and same no
>> DeprecationWarning.
>>> Im trying to find why only DC1 has this message even after
>> the i reverted to
>>> the VM backup.
>>>
>>> So i hoped today that after the fix for 4.13 for the start
>> up, i did an
>>> upgrade again on my production DC1, having the
>> DeprecationWarning message
>>> Only that didnt solve it. Its all running fine thats not
>> the problem.
>>> Strange thing here is, DC2
>>> is a copy of DC1 and doesnt show this and same for the new DC setup.
>>>
>>> Anyone suggestions
>>>    what this is, and maybe how to make the error disapear?
>>>
>>> Its a very constant message since i see it every 10 minuts.
>> You would, that is the frequency that samba_dnsupdate is run.
>>
>> Could you be running bullseye on that DC ?
> No, im sure this is buster ;-)
>
>> Which would mean python3-dnspython V2.0.0 and in this version
>> resolver.query is deprecated.
>>
> Good one, i checked this.
>
> DC1  :
> dpkg-query -s python3-dnspython
> Package: python3-dnspython
> Status: install ok installed
> Priority: optional
> Section: python
> Installed-Size: 618
> ...
>
> Same on all DC's.
>
>
> All run the following setting with netbios name changed offcourse.
> [global]
>          netbios name = RTD-DC0
>          workgroup = ADDOM
>          realm = ADDOM.INTERNAL.TLD
>
>          server role = active directory domain controller
>          server services = -dns -spoolss
>          idmap_ldb:use rfc2307 = yes
>
>          # + A manual setup for TLS/SSL Certificates.
>          tls keyfile = /etc/ssl/local/private/xxxxxxxxxx.key.pem
>          tls certfile = /etc/ssl/local/certs/xxxxxxxxxx.cert.pem
>          tls cafile = /etc/ssl/local/certs/xxxxxxxxxx-ca.pem
>
>          template shell = /bin/bash
>          template homedir = /home/users/%U
>
>          load printers = no
>          printcap name = /dev/null
>
>          ntlm auth = mschapv2-and-ntlmv2-only
>
> And the shares offcourse..  So nothing fancy.
>
> Other options?
>
> And thanks for the reply :-)
>
> Greetz,
>
> Louis
>
>
>
OK, you are running buster but you must be running python3-dnspython 
version 2.0.0 because that error message is coming from that version, it 
has nothing to do with Samba:

     def query(self, qname, rdtype=dns.rdatatype.A, 
rdclass=dns.rdataclass.IN,
               tcp=False, source=None, raise_on_no_answer=True, 
source_port=0,
               lifetime=None):  # pragma: no cover
         """Query nameservers to find the answer to the question.

         This method calls resolve() with ``search=True``, and is
         provided for backwards compatbility with prior versions of
         dnspython.  See the documentation for the resolve() method for
         further details.
         """
         warnings.warn('please use dns.resolver.Resolver.resolve() instead',
                       DeprecationWarning, stacklevel=2)
         return self.resolve(qname, rdtype, rdclass, tcp, source,
                             raise_on_no_answer, source_port, lifetime,
                             True)

Version 1.16.0 (which Buster should be using) does not have the 
'DeprecationWarning'.

Rowland