git signoff+ and review+

Andrew Bartlett abartlet at
Wed Jun 10 07:20:51 UTC 2020

On Wed, 2020-06-10 at 09:28 +0300, Uri Simchoni wrote:
> On 6/10/20 8:27 AM, Andreas Schneider via samba-technical wrote:
> > 
> > I'm not sure how you exactly want to achieve that. Please educate
> > me and then 
> > I can help you :-)
> > 
> How about adding those scripts to Samba, and adding a "samba-git-
> config"
> script that would set them up (and then the honorable mentions in the
> wiki and/or README.Coding)?

When we run ./configure we already set up the 
.git/hooks/pre-commit for the whitespace check.  What I'm suggesting is
that we get a good agreed set of commands and install them on a per-
repo basis using git config as aliases. 

Then we can document them (of course) but even more helpfully reference
them without major qualification from our wiki, README.Coding, etc,
because they will always be ready to use. 

Andrew Bartlett
Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT 

More information about the samba-technical mailing list