git signoff+ and review+

Uri Simchoni uri at samba.org
Wed Jun 10 06:28:45 UTC 2020


On 6/10/20 8:27 AM, Andreas Schneider via samba-technical wrote:
> On Friday, 5 June 2020 11:15:22 CEST Andrew Bartlett via samba-technical 
> wrote:
>> On Fri, 2020-06-05 at 09:56 +0200, Andreas Schneider wrote:
>>> On Friday, 5 June 2020 02:06:56 CEST Andrew Bartlett wrote:
>>>> G'Day Andreas,
>>>
>>> Hi Andrew,
>>>
>>>> I wondered if we could have an agreed set of aliases included in
>>>> Samba?
>>>
>>> You cannot include those in the Samba repository. Those are all
>>> individual.
>>> All you can do, is provide a script which could set them up running
>>> 'git
>>> config'.
>>
>> Do you mean we can't do it technically, or we shouldn't do it because
>> we are all individual developers with our own way of doing things?
> 
> I'm not sure how you exactly want to achieve that. Please educate me and then 
> I can help you :-)
> 

How about adding those scripts to Samba, and adding a "samba-git-config"
script that would set them up (and then the honorable mentions in the
wiki and/or README.Coding)?



More information about the samba-technical mailing list