Document GitLab as the only way to contribute to Samba?

Martin Schwenke martin at
Wed Sep 11 01:34:18 UTC 2019

On Fri, 06 Sep 2019 16:54:17 +1200, Andrew Bartlett via samba-technical
<samba-technical at> wrote:

> On Fri, 2019-06-28 at 00:31 +0200, Michael Adam wrote:
> > 
> > I personally think that mail list reviews do have some advantages
> > but the gitlab system also has several advantages.
> > 
> > So I would in general be fine with the change.
> > 
> > Not sure if it would help to first declare the ML submissions
> > deprecated and in a second step declare gitlab the only way to
> > submit?  
> So, after all that and some water under the bridge, can we please agree
> to go ahead and make that change, for the sake of clarity and
> consistency?
> I would document it as (roughly):
> - GitLab is the strongly perferred method to contribute to Samba. 
> - Patches mailed to the mailing list may still be considered, but
> require additional work on the part of Samba Team members so are
> discouraged. 
> If you are interested in reviewing patches submitted to Samba, please
> ensure you have a account and are watching our public gitlab
> repository. 

Sorry, but NACK.

Samba is a Free Software project.  While that is true we must not
mandate a proprietary platform as the only way of contributing.  Nor
should we discourage contributions that are not made via a proprietary

There are many reasons why a new contributor may be unable to use
GitLab, including:

* They may not agree with the terms of service

* They may not wish to take the time to setup an account and be added
  to the required project

* They may find the user interface unusable

* They may not have (reliable) web access

They may still be able to make very worthwhile contributions.

Ironically, Git - and, therefore, GitLab - exists because the founder of
the Samba project did not think it reasonable for a proprietary product
to be mandated for development on another project.

More pragmatically, GitLab may go away, so we should keep our options
not only open but also active.

We should continue to encourage this mailing list as an option for
contributing to Samba.  If a reviewer prefers seeing a GitLab CI
pipeline pass before they look at code then, if a mailing list
contribution sounds interesting, they can save the patch, run "git am"
and push the resulting branch to GitLab GI in less than a minute or 2.
They can then reply to the contributor saying "looks interesting,
waiting for GitLab CI pipeline <url> to complete".  This mailing list
isn't so busy that hand-processing a few contributions will swamp any
reviewer's time.

Sorry, mate!  This is a hill I'm willing to die on...

peace & happiness,

More information about the samba-technical mailing list