Converting SMB1 tests to SMB2

[Jeremy Allison]

On Fri, Sep 27, 2019 at 02:54:08PM +0000, David Mulder via samba-technical wrote:
> Noel and I are looking at converting any old SMB tests that target the SMB1 protocols to SMB2+. Is anyone else already working on this? Does anyone have some pointers?

"Congratulations, you've decided to clean the elevator... !" (from
the movie Dark Star :-).

No, no one else is working on this I'm afaid. As I add
new tests I usually make sure they're SMB2+ only, as
that's what we want to target going forward.

Best advice I can give is to move them over one
at a time, probably starting with the isolated
ones.

As you move them, take the opportunity to clean
up some of the old failure paths - ensuring they
start and end with a clean and empty directory
tree. Some of our flaky tests have been caused
by 'old' data being left from a previous test.