[PATCH]: winbind handling NULL sids (bug #13914)

Ralph Boehme slow at samba.org
Tue May 28 09:56:40 UTC 2019


On Tue, May 28, 2019 at 12:47:05PM +0530, Amit Kumar wrote:
>Created merge request:
>https://gitlab.com/amitkuma/samba/commit/1a6f331445364de623d02425c8d8b46a59eb2c53

Thanks! Unfortunately you targetted the wrong repo (samba-team/devel/samba 
instead of samba-team/samba).

Please follow the instructions at
<https://wiki.samba.org/index.php/Samba_CI_on_gitlab#Other_Samba_developers>

>
>Attached patch as well.
>(0001-s3-winbind-Not-abort-when-received-NULL-SID.patch)

you're somehow munging the patches, replacing tabs for spaces, that's why the 
patch again doesn't apply.

Looking at the patch, I wonder whether we should skip the trusts with null-sid 
instead of adding them?

-slow

-- 
Ralph Boehme, Samba Team                https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG-Fingerprint   FAE2C6088A24252051C559E4AA1E9B7126399E46



More information about the samba-technical mailing list