[PATCH]: winbind handling NULL sids (bug #13914)

[Amit Kumar]

Hello slow,

Created merge request:
https://gitlab.com/amitkuma/samba/commit/1a6f331445364de623d02425c8d8b46a59eb2c53

Attached patch as well.
(0001-s3-winbind-Not-abort-when-received-NULL-SID.patch)

Thanks


On 05/27/2019 07:38 PM, Ralph Boehme wrote:
> On Mon, May 27, 2019 at 05:05:54PM +0530, Amit Kumar via
> samba-technical wrote:
>> Created patch using following command set:
>> # git clone https://github.com/samba-team/samba
>> # cd samba
>> Done changes
>> # # git checkout -b null-sid
>> M    source3/winbindd/winbindd_rpc.c
>> Switched to a new branch 'null-sid'
>> # git add source3/winbindd/winbindd_rpc.c
>> # git commit -m "winbind null sid handling"
>> # git format-patch -1 HEAD
>> 0001-winbind-null-sid-handling.patch
>
> hm, still fail:
>
> slow at inti:autobuild ▸ git log --oneline -1 HEAD
> 412afb2aef1 (HEAD -> ab, origin/master, gitlab/master) Fix ubsan null
> pointer passed as argument 2
>
> slow at inti:autobuild ▸ git am
> ~/patches/0001-winbind-null-sid-handling.patch
> Applying: winbind null sid handling
> error: patch failed: source3/winbindd/winbindd_rpc.c:958
> error: source3/winbindd/winbindd_rpc.c: patch does not apply
> Patch failed at 0001 winbind null sid handling
> hint: Use 'git am --show-current-patch' to see the failed patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> Can you check?
>
> While at it, can you please add a bit more desciptive text to the
> commit message describing the problem and the fix? Thanks!
>
> Finally please also add your signed-off by once you're happy with the
> state of your patch:
>
> https://wiki.samba.org/index.php/CodeReview#commit_message_tags
>
> Thanks!
> -slow
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-winbind-Not-abort-when-received-NULL-SID.patch
Type: text/x-patch
Size: 3106 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190528/213caf58/0001-s3-winbind-Not-abort-when-received-NULL-SID.bin>