[PATCH] check load printers prior to pcap cache update

David Disseldorp ddiss at samba.org
Tue Jan 29 12:34:44 UTC 2019


According to the smb.conf man page, the "load printers" smb.conf global
should have the following effect:

  A boolean variable that controls whether all printers in the printcap
  will be loaded for browsing by default.
  See the <smbconfoption name="printers"/> section for more details.

lp_load_printers() is currently only checked in the load_printers()
code-path prior to pcap_printer_read_fn(). It should also be considered
in the pcap_cache_reload() code path.

Review/push appreciated.

Patchset is attached, and can also be found at:
https://gitlab.com/samba-team/samba/merge_requests/228

Cheers, David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_lp_load_printers.patchset
Type: text/x-patch
Size: 4493 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20190129/999fbfd6/check_lp_load_printers.bin>


More information about the samba-technical mailing list