[PATCH] check load printers prior to pcap cache update

Noel Power nopower at suse.com
Thu Jan 31 09:38:57 UTC 2019

On 29/01/2019 12:34, David Disseldorp via samba-technical wrote:
> According to the smb.conf man page, the "load printers" smb.conf global
> should have the following effect:
>   A boolean variable that controls whether all printers in the printcap
>   will be loaded for browsing by default.
>   See the <smbconfoption name="printers"/> section for more details.
> lp_load_printers() is currently only checked in the load_printers()
> code-path prior to pcap_printer_read_fn(). It should also be considered
> in the pcap_cache_reload() code path.
> Review/push appreciated.
> Patchset is attached, and can also be found at:
> https://gitlab.com/samba-team/samba/merge_requests/228
> Cheers, David


RB+ Since I am not a (not want to be) familiar with printing I will wait
a day or so before pushing incase there is some objection


More information about the samba-technical mailing list