[PATCH] ldb: Run at least some tests on 32 bit machines

Andrew Bartlett abartlet at samba.org
Sat Jan 19 08:55:57 UTC 2019

On Fri, 2019-01-18 at 17:27 +0100, Lukas Slebodnik via samba-technical
> ehlo,
> This is a rebased version of patch which I sent 8 months ago.
> https://lists.samba.org/archive/samba-technical/2018-May/128212.html
> Since the release of 1.4.0, there were 5 new releases.
> And Just one test was added and it was not related to lmdb.
> IMHO it make sense to run at lease some unit tests if people decide
> to build libldb without lmdb. And it is not just about 32 bit
> architectures.
> Some distributions needn't have lmdb for various reasons.

In the other places where this was raised I said I would only accept
this if a negative test is added, that fails if LMDB is built but the
test system thinks it isn't built.  Otherwise it is exceptionally easy
for these to get out of sync, and the tests not to get run.  

This has happened before. 

I didn't say that to you directly however, and I acknowledge that this
has been requested from multiple distributions.  The other request was
here from Debian:


If you or Mathieu can do that, I'll accept such a patch.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list