[PATCH] ldb: Run at least some tests on 32 bit machines

Andrew Bartlett abartlet at samba.org
Wed May 30 22:39:18 UTC 2018


On Thu, 2018-05-31 at 00:00 +0200, Lukas Slebodnik via samba-technical
wrote:
> ehlo,
> 
> Please consider merging the patch. It simplify packaging (running unit tests)
> in downstream with multiple architecture supported (fedora)
> 
> BTW May I know a reason why ldb-mdb id not supported on 32 bit architectures?
> Because lmdb is build for all architectures on fedora
> https://koji.fedoraproject.org/koji/buildinfo?buildID=1075088

I'm sorry, but the choice here is deliberate.  We find that conditional
tests cause tests to go missing really fast.

To get tests going on a 32 bit machine we need a way to have the map
size slowly expand, which we don't yet have, or to set the map small
(eg 256MB) and have some way to signal to Samba never to provision LMDB
on such a host (because mapping even 256MB multiple times - as sam.ldb
does won't end well).

Sorry,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list