[PATCH] remove "ExistingBackend" provision backend and 28 other python patches

Noel Power nopower at suse.com
Wed Oct 31 10:47:13 UTC 2018

On 28/10/2018 21:39, Douglas Bagnall via samba-technical wrote:
> We have this class in the provision code called "ExistingBackend" which
> seems so full of unrunnable code that I deduce that nobody ever uses it.
> So let's remove it.
> I have hidden that patch in the middle of a series of trivial python patches
> that fix basic errors (like the number of "%s"s not matching the number of
> format arguments), so that anyone who wants to bikeshed it will have to review
> the lot. If you don't want to bikeshed, please review anyway!
> cheers,
> Douglas

  [PATCH 24/29] python/ms_forest_updates_markdown: avoid implicit
  global variable

-    read_ms_markdown(in_file, out_folder)
+    read_ms_markdown(in_file, out_folder, {})

That looks wrong to me, read_ms_markdown looks like it takes a file or 
dictionary, it looks like the code will prefer the file if both are 
specified but read_ms_markdown should either pass a temp dict to 
save_array routine or save_array should handle the None dict, it should 
handle the None default gracefully

other than that, the rest look good to me, RB+ for me


More information about the samba-technical mailing list