[PATCH] remove "ExistingBackend" provision backend and 28 other python patches

Douglas Bagnall douglas.bagnall at catalyst.net.nz
Wed Oct 31 20:57:27 UTC 2018

On 31/10/18 11:47 PM, Noel Power wrote:
>  [PATCH 24/29] python/ms_forest_updates_markdown: avoid implicit
>  global variable
> -    read_ms_markdown(in_file, out_folder)
> +    read_ms_markdown(in_file, out_folder, {})
> That looks wrong to me, read_ms_markdown looks like it takes a file or
> dictionary, it looks like the code will prefer the file if both are
> specified but read_ms_markdown should either pass a temp dict to
> save_array routine or save_array should handle the None dict, it should
> handle the None default gracefully

Right. It just needs the attached version then? I think you are right
and it looks clearer.

> other than that, the rest look good to me, RB+ for me

thank you.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-python-ms_forest_updates_markdown-avoid-implicit-glo.patch
Type: text/x-patch
Size: 1061 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181101/1f244ed0/0001-python-ms_forest_updates_markdown-avoid-implicit-glo.bin>

More information about the samba-technical mailing list