[PATCH] get_interfaces() return early causes segfault in winbind

David Mulder dmulder at suse.com
Thu Oct 25 18:37:34 UTC 2018

Yes, this is present in 4.9.1.

On 10/25/2018 10:12 AM, Ralph Böhme via samba-technical wrote:
> On Thu, Oct 25, 2018 at 09:18:53AM -0600, David Mulder via
> samba-technical wrote:
>> Regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.
>> If we return early, be sure to point pifaces to the returned ifaces if
>> we have 1 return. Otherwise winbind segfaults in load_interfaces() if
>> there is only 1 interface, because we say there is 1 interface, but
>> ifaces is NULL (load_interfaces() tries to smb_memdup NULL of iface
>> size 1).
>> Seen on a machine where dhcp was slow to return, so winbind crashed on
>> started due to lo being the only interface available on start.
>> Please review and push if ok!
> lgtm.
> Can I get a second team member review?
> Also, is this present in 4.9? If so, we need a bug for the bugnumber
> for the backports. :)
> -slow

David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)

More information about the samba-technical mailing list