[PATCH] get_interfaces() return early causes segfault in winbind
slow at samba.org
Thu Oct 25 16:12:01 UTC 2018
On Thu, Oct 25, 2018 at 09:18:53AM -0600, David Mulder via samba-technical wrote:
>Regression caused by da68a1b2f417ec82ea4ed3e7a4d867cef8ca8f93.
>If we return early, be sure to point pifaces to the returned ifaces if
>we have 1 return. Otherwise winbind segfaults in load_interfaces() if
>there is only 1 interface, because we say there is 1 interface, but
>ifaces is NULL (load_interfaces() tries to smb_memdup NULL of iface size 1).
>Seen on a machine where dhcp was slow to return, so winbind crashed on
>started due to lo being the only interface available on start.
>Please review and push if ok!
Can I get a second team member review?
Also, is this present in 4.9? If so, we need a bug for the bugnumber for the
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
More information about the samba-technical