[PATCH] Fix AppleDouble conversion in vfs_fruit

Ralph Böhme slow at samba.org
Wed Oct 10 20:49:53 UTC 2018

On Wed, Oct 10, 2018 at 01:32:34PM -0700, Jeremy Allison wrote:
>On Wed, Oct 10, 2018 at 10:27:15PM +0200, Ralph Böhme wrote:
>> On Wed, Oct 10, 2018 at 11:20:04AM -0700, Jeremy Allison wrote:
>> > I think you should initialize converted_xattr
>> > at declaration as:
>> >
>> > +       bool converted_xattr = false;
>> >
>> > With that change, RB+. Do you want me to make that change and push ?
>> scaredy-cat band-aid. Pushed with that change. :)))
>I'm not disagreeing, but if the code flow changes in the future you might get a 
>"used uninitialized variable" error.
>Do you want that responsibility ? Well, do you ?  DO YOU !!!! :-) :-).

an out arg is an out arg. If a called function with out args returns success, 
the out arg MUST be set to some value. Everything else is paving over an insane 
state of mind. Just saying, otoh I don't want *that* responsibility. :)


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list