[PATCH] Fix AppleDouble conversion in vfs_fruit

Ralph Böhme slow at samba.org
Tue Oct 9 13:11:00 UTC 2018

On Tue, Oct 09, 2018 at 01:00:23PM +0200, Ralph Böhme via samba-technical wrote:
>On Tue, Oct 09, 2018 at 12:35:22PM +0200, Ralph Böhme wrote:
>>please hold on, something's fishy. This was passing manual make test 
>>vfs.fruit whereas it's now failing. Checking...
>The culprit was a last minute change in 3/21 to use a pointer instead 
>of an array to store the filler bytes. The problem is that whenever 
>ad_pack() is called it overwrites the original filler bytes.
>So attached is the original version of the patchset without this 
>change. Passes manual make test vfs.fruit again.
>CI: https://gitlab.com/samba-team/devel/samba/pipelines/32396036

failed on an unrelated test.

New CI: https://gitlab.com/samba-team/devel/samba/pipelines/32409953


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list