|PATCH] dsdb group audit test : Fix string compares
Gary Lockyer
gary at catalyst.net.nz
Sun Nov 18 20:11:49 UTC 2018
New patch set with requested changes.
CI run: https://gitlab.com/samba-team/devel/samba/pipelines/37033885
Thanks
Gary
On 15/11/18 21:24, Andreas Schneider wrote:
> On Wednesday, 14 November 2018 21:38:25 CET Gary Lockyer via samba-technical
> wrote:
>> Replace the uses of:
>> strncmp(expected, value, strlen(expected))
>> With:
>> strcmp(expected, value)
>
> I've you're already changing it, please do:
>
> int cmp;
>
> cmp = strcmp("groupChange", value);
> if (cmp != 0)
> ...
>
> for both hunks ...
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20181119/39c80600/signature.sig>
More information about the samba-technical
mailing list