|PATCH] dsdb group audit test : Fix string compares

Andreas Schneider asn at samba.org
Thu Nov 15 08:24:52 UTC 2018


On Wednesday, 14 November 2018 21:38:25 CET Gary Lockyer via samba-technical 
wrote:
> Replace the uses of:
>     strncmp(expected, value, strlen(expected))
> With:
>     strcmp(expected, value)

I've you're already changing it, please do:

int cmp;

cmp = strcmp("groupChange", value);
if (cmp != 0)
...

for both hunks ...

-- 
Andreas Schneider                      asn at samba.org
Samba Team                             www.samba.org
GPG-ID:     8DFF53E18F2ABC8D8F3C92237EE0FC4DCC014E3D





More information about the samba-technical mailing list