[PATCH] make --with-{gpgme,json-audit,libarchive} the default, finish --without-json-audit docs
Andrew Bartlett
abartlet at samba.org
Mon May 14 04:20:29 UTC 2018
On Mon, 2018-05-14 at 07:09 +1200, Andrew Bartlett wrote:
> On Sun, 2018-05-13 at 12:34 +0200, Stefan Metzmacher via samba-
> technical wrote:
> >
> > Please change
> > DEBUG(0, ("tar mode not compiled. build was --without-libarchive\n"))
> > into
> > DEBUG(0, ("tar mode not compiled. build used --without-libarchive\n"))
>
> Thanks. That is much better.
>
> > The indentation of the section starting with
> > conf.fatal("GPGME support not found. "
> > seems to be wrong, it changed to what we had before
> > and the following lines are not all the same...
> >
> > The same applies to
> > conf.fatal("JSON support not found. " which seem to have 9 leading
> > spaces, the following lines seem to be ok if it's reduced to 8.
>
> I'll see what happened there.
>
> > Otherwise it looks good to me.
>
> Thanks metze. I will clean that up shortly.
>
> Andrew Bartlett
Thanks. Gary gave it another eye-ball over and I've pushed it to
autobuild with reviewed-by from both of you.
Andrew Bartlett
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list