Removing --disable-python again for the standalone libs (broken)?

Andrew Bartlett abartlet at samba.org
Thu May 10 03:08:13 UTC 2018


On Wed, 2018-05-09 at 19:59 -0700, Jeremy Allison wrote:
> 
> > Jeremy:  This looks like a ChromeOS thing?
> > 
> > https://groups.google.com/a/chromium.org/forum/#!topic/chromium-os-revi
> > ews/p1lEcMai8Qg
> 
> Yes, I think this a cross-compilation thing ChromeOS needs to build
> on arm.

Ahh.  Yes, cross-compile and python are not friends. 

> We should fix --disable-python I think.

Can you take charge of it?  I know it's waf foo (so you will be
delegating fast) but I've got to much else to juggle to dig in further.
 

Once fixed, apply my autobuild patch to keep it that way.

As a hint, this slab of lib/ldb/wscript looks deeply suspicious:

    if bld.PYTHON_BUILD_IS_ENABLED():
        if not bld.CONFIG_SET('USING_SYSTEM_PYLDB_UTIL'):
            for env in bld.gen_python_environments(['PKGCONFIGDIR']):
               # we're not currently linking against the ldap libs, but
ldb.pc.in
                # has @LDAP_LIBS@
                bld.env.LDAP_LIBS = ''

                if not 'PACKAGE_VERSION' in bld.env:
                    bld.env.PACKAGE_VERSION = VERSION
                    bld.env.PKGCONFIGDIR = '${LIBDIR}/pkgconfig'

It needs to be inside the loop because 'env' gets duplicated by the
gen_python_environments hack, but I'm guessing it needs to be set
regardless. 

Thanks, 

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list