Removing --disable-python again for the standalone libs (broken)?

[Timur I. Bakeyev]

Hi, all!

I patched that for ldb-1.3.0 in the FreeBSD ports, when it was released, as
we also have people who don't want Python to be introduced on there
systems, but forgot/didn't yet have time to send the patch to the list.

So, here how I did it.

With regards,
Timur


On 10 May 2018 at 05:08, Andrew Bartlett via samba-technical <
samba-technical at lists.samba.org> wrote:

> On Wed, 2018-05-09 at 19:59 -0700, Jeremy Allison wrote:
> >
> > > Jeremy:  This looks like a ChromeOS thing?
> > >
> > > https://groups.google.com/a/chromium.org/forum/#!topic/
> chromium-os-revi
> > > ews/p1lEcMai8Qg
> >
> > Yes, I think this a cross-compilation thing ChromeOS needs to build
> > on arm.
>
> Ahh.  Yes, cross-compile and python are not friends.
>
> > We should fix --disable-python I think.
>
> Can you take charge of it?  I know it's waf foo (so you will be
> delegating fast) but I've got to much else to juggle to dig in further.
>
>
> Once fixed, apply my autobuild patch to keep it that way.
>
> As a hint, this slab of lib/ldb/wscript looks deeply suspicious:
>
>     if bld.PYTHON_BUILD_IS_ENABLED():
>         if not bld.CONFIG_SET('USING_SYSTEM_PYLDB_UTIL'):
>             for env in bld.gen_python_environments(['PKGCONFIGDIR']):
>                # we're not currently linking against the ldap libs, but
> ldb.pc.in
>                 # has @LDAP_LIBS@
>                 bld.env.LDAP_LIBS = ''
>
>                 if not 'PACKAGE_VERSION' in bld.env:
>                     bld.env.PACKAGE_VERSION = VERSION
>                     bld.env.PKGCONFIGDIR = '${LIBDIR}/pkgconfig'
>
> It needs to be inside the loop because 'env' gets duplicated by the
> gen_python_environments hack, but I'm guessing it needs to be set
> regardless.
>
> Thanks,
>
> Andrew Bartlett
> --
> Andrew Bartlett
> https://samba.org/~abartlet/
> Authentication Developer, Samba Team         https://samba.org
> Samba Development and Support, Catalyst IT
> https://catalyst.net.nz/services/samba
>
>
>
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-wscript
Type: application/octet-stream
Size: 1312 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180510/a39b4392/patch-wscript.obj>